Keep agent completions unread until their pane is viewed - #781
Open
onevpaw wants to merge 5 commits into
Open
Conversation
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep completed panes unread until they are viewed in the active, visible Prowl window. Use the shared viewing predicate for polling and automatic focus acknowledgement, including a fresh visibility check after asynchronous session resolution.
Preserve acknowledgements made while session resolution is suspended, including their timestamp. Discard the pending observation if other pane state changed during suspension. A later unviewed working/blocked-to-idle transition still becomes Done.
Fixes #777.
Validation
make checkpassed, including 146 script tests.make build-apppassed.git diff --checkpassed.Related work and credit
Thanks to @SunChJ for the original implementation in #778, resubmitted as #782, and to @onevtail for identifying the session-resolution race in that review. This PR consolidates the shared fix with behavior-level regression coverage and resolves that race. #783 is the separate Canvas viewing companion.